chore: update submodule: eloqstore bug fixs and automatic config of eloqstore disk limits#239
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR updates the data_substrate submodule commit reference from aa2703c81b190dd7a41a82e1c1c04170b6c28ffd to 962933b1ca097a155783a02bf360e7a6158a1b98. No API or behavioral changes detected. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thweetkomputer
force-pushed
the
fix-release-order-zc
branch
2 times, most recently
from
77d518e to
b3b5b7d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
concourse/scripts/mtr_bootstrap_ds.cnf (1)
15-16: Avoid hardcoding static object-store credentials in repo configs.Line 15, Line 16, Line 22, and Line 23 commit fixed credentials directly. Even for test MinIO, this weakens secret hygiene and encourages reuse. Prefer injecting these values from CI/environment or a local untracked override file.
Also applies to: 22-23
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@concourse/scripts/mtr_bootstrap_ds.cnf` around lines 15 - 16, Remove the hardcoded credentials (aws_access_key_id and aws_secret_key) from the config and replace them with injected values (e.g., reference environment variables or a local untracked override). Update the config entries to read from placeholders like ${MINIO_ACCESS_KEY} and ${MINIO_SECRET_KEY} or document that these should be provided by CI/runtime env; ensure any local developer override file is .gitignored and mention the same change for the other occurrences of aws_access_key_id/aws_secret_key in this diff.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@concourse/scripts/mtr_bootstrap_ds.cnf`:
- Around line 15-16: Remove the hardcoded credentials (aws_access_key_id and
aws_secret_key) from the config and replace them with injected values (e.g.,
reference environment variables or a local untracked override). Update the
config entries to read from placeholders like ${MINIO_ACCESS_KEY} and
${MINIO_SECRET_KEY} or document that these should be provided by CI/runtime env;
ensure any local developer override file is .gitignored and mention the same
change for the other occurrences of aws_access_key_id/aws_secret_key in this
diff.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
concourse/scripts/mtr_bootstrap.cnfconcourse/scripts/mtr_bootstrap_ds.cnfdata_substratestorage/eloq/mysql-test/mono_basic/data_substrate.cnfstorage/eloq/mysql-test/mono_main/data_substrate.cnfstorage/eloq/mysql-test/mono_main/my.cnf
✅ Files skipped from review due to trivial changes (2)
- concourse/scripts/mtr_bootstrap.cnf
- storage/eloq/mysql-test/mono_main/my.cnf
🚧 Files skipped from review as they are similar to previous changes (1)
- data_substrate
thweetkomputer
force-pushed
the
fix-release-order-zc
branch
from
ddf8c22 to
6080e21
Compare
thweetkomputer
changed the title
thweetkomputer
force-pushed
the
fix-release-order-zc
branch
2 times, most recently
from
4d5dcbd to
05ec2ce
Compare
thweetkomputer
force-pushed
the
fix-release-order-zc
branch
from
15aa6ee to
a9a14af
Compare
2 participants
Summary by CodeRabbit